Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: add WithConnectParams to configure connection backoff and timeout #2960

Merged
merged 10 commits into from Oct 3, 2019

Commits on Sep 30, 2019

  1. Implement missing pieces for connection backoff.

    Spec can be found here:
    https://github.com/grpc/grpc/blob/master/doc/connection-backoff.md
    
    Summary of changes:
    * Added a new type (marked experimental), ConnectParams, which contains
      the knobs defined in the spec (except for minConnectTimeout).
    * Added a new API (marked experimental), WithConnectParams() to return a
      DialOption to dial with the provided parameters.
    * Added new fields to the implementation of the exponential backoff in
      internal/backoff which mirror the ones in ConnectParams.
    * Marked existing APIs WithBackoffMaxDelay() and WithBackoffConfig() as
      deprecated.
    * Added a default exponential backoff implementation, for easy use of
      internal callers.
    easwars committed Sep 30, 2019
    Copy the full SHA
    32275fc View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    f8b4003 View commit details
    Browse the repository at this point in the history
  3. Handle review comments.

    Added a new backoff package which defines the backoff configuration
    options, and is used by both the grpc package and the internal/backoff
    package. This allows us to have all backoff related options in a
    separate package.
    easwars committed Sep 30, 2019
    Copy the full SHA
    0f7db76 View commit details
    Browse the repository at this point in the history
  4. Make vet happy.

    easwars committed Sep 30, 2019
    Copy the full SHA
    0115f00 View commit details
    Browse the repository at this point in the history
  5. vets and comments

    easwars committed Sep 30, 2019
    Copy the full SHA
    dea6444 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    f5998d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Review comments.

    easwars committed Oct 2, 2019
    Copy the full SHA
    3fce38e View commit details
    Browse the repository at this point in the history
  2. Make vet happy.

    easwars committed Oct 2, 2019
    Copy the full SHA
    e1a1470 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2019

  1. Copy the full SHA
    ebebd7d View commit details
    Browse the repository at this point in the history
  2. Review comments.

    easwars committed Oct 3, 2019
    Copy the full SHA
    cc7872c View commit details
    Browse the repository at this point in the history