client: include name resolution error in RPC errors #2831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[resolver_error] in dns, report error when lookupHost() fails [resolver_error] (s)
|
This change gets complicated with service config. (What to do if we get an error fetching addresses, but get service config? Do we apply the service config or also drop it?). We may end up needing more than just one err fields. The error handling logic needs more discussion, we will send an update when there's a conclusion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to last connection error.
DNS resolver reports error only when
lookupHost()fails.Note that this PR doesn't make non-WaitForReady RPCs failfast, and they will still fail after timeout.
#2102