Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing pieces for connection backoff. #2821

Closed
wants to merge 20 commits into from

Commits on Aug 6, 2019

  1. Configuration menu
    Copy the full SHA
    49cecd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    01955d6 View commit details
    Browse the repository at this point in the history
  3. Handle review comments.

    Move MinConnectionTimeout() out of backoff.Strategy interface. Store
    it directly in dialOptions instead, and have ClientConn use it from
    there.
    easwars committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    00e65e2 View commit details
    Browse the repository at this point in the history
  4. Handle vet failure.

    easwars committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    a0d005b View commit details
    Browse the repository at this point in the history
  5. Rollback changes made as part of grpc#2735.

    I need to roll these back because I had sent out changes from my master
    branch, and this is causing a lot of pain right now for my work on other
    branches. I will create a branch for this issue and will send out these
    changes in a fresh PR.
    easwars committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    60f9a60 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    57439d9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a8ef06a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    452f9d8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4ce3ef2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a2bdfb4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1d7ad57 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5364181 View commit details
    Browse the repository at this point in the history
  13. Handle review comments.

    Move MinConnectionTimeout() out of backoff.Strategy interface. Store
    it directly in dialOptions instead, and have ClientConn use it from
    there.
    easwars committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    df8677a View commit details
    Browse the repository at this point in the history
  14. Handle vet failure.

    easwars committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    a1307ea View commit details
    Browse the repository at this point in the history
  15. Rollback changes made as part of grpc#2735.

    I need to roll these back because I had sent out changes from my master
    branch, and this is causing a lot of pain right now for my work on other
    branches. I will create a branch for this issue and will send out these
    changes in a fresh PR.
    easwars committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    b084e74 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6315c5d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e8de2c2 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    7f27715 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4461214 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    43d4e84 View commit details
    Browse the repository at this point in the history