Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dial option to set balancer #1697

Merged
merged 3 commits into from Dec 18, 2017
Merged

Add dial option to set balancer #1697

merged 3 commits into from Dec 18, 2017

Commits on Dec 15, 2017

  1. Add withbalancername dial option 

    service config will not override dial option balancer
fix comments
Add const roundrobin.Name and PickFirstBalancerName.
remove WithBalancerBuilder
fix tests
delete withBalancerBuilder
    @menghanl
    menghanl committed Dec 15, 2017
    Copy the full SHA
    83c5ac8 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @menghanl
    menghanl committed Dec 15, 2017
    Copy the full SHA
    e488e4c View commit details
    Browse the repository at this point in the history

  3. Use balancerBuilder to implement WithBalancerName 

    And make WithBalancerName panic if no balancer is registered
    @menghanl
    menghanl committed Dec 15, 2017
    Copy the full SHA
    22cfa02 View commit details
    Browse the repository at this point in the history