Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickfirst must move to TransientFailure if it receives empty addresses #5260

Closed
easwars opened this issue Mar 21, 2022 · 1 comment
Closed
Assignees

Comments

@easwars
Copy link
Contributor

easwars commented Mar 21, 2022

Our round_robin LB policy implementation moves to TransientFailure when it receives an update with empty addresses from the resolver (even if it had valid addresses in the past and was Ready). Other languages have the same behavior for round_robin and pick_first.

Our pick_first implementation though, doesn't move to TransientFailure upon receipt of an update with empty addresses if it already has valid addresses. See: https://github.com/grpc/grpc-go/blob/master/pickfirst.go#L54-L59

This needs to change to align with the implementations in other languages.

@easwars
Copy link
Contributor Author

easwars commented Mar 29, 2022

Fixed by #5274.

@easwars easwars closed this as completed Mar 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant