binarylog: Don't continue after failing to marshal the proto

and log the error as an Error rather than Info
grpc · Jul 8, 2021 · e5d747d · e5d747d
1 parent 91e0aeb
commit e5d747d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/internal/binarylog/sink.go b/internal/binarylog/sink.go
@@ -69,7 +69,8 @@ type writerSink struct {
 func (ws *writerSink) Write(e *pb.GrpcLogEntry) error {
 	b, err := proto.Marshal(e)
 	if err != nil {
-		grpclogLogger.Infof("binary logging: failed to marshal proto message: %v", err)
+		grpclogLogger.Errorf("binary logging: failed to marshal proto message: %v", err)
+		return err
 	}
 	hdr := make([]byte, 4)
 	binary.BigEndian.PutUint32(hdr, uint32(len(b)))