-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: fix Test/GracefulStop by not removing activeStreams too aggresi…
…velly (#2857) Before this fix, stream is removed from activeStreams in finishStream, which happens when the service handler returns status, without waiting for the status to be sent by loopyWriter. If GracefulStop() is called in between, it will close the connection (because activeStreams is empty), which causes the RPC to fail with "transport is closing". This change moves the activeStreams cleanup into loopyWriter, after sending status on wire.
- Loading branch information
Showing
3 changed files
with
87 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters