Skip to content

Commit

Permalink
xds: de-experimentalize google c2p resolver (#5707)
Browse files Browse the repository at this point in the history
  • Loading branch information
apolcyn committed Oct 12, 2022
1 parent 8b3b10b commit 9eba574
Showing 1 changed file with 14 additions and 5 deletions.
19 changes: 14 additions & 5 deletions xds/googledirectpath/googlec2p.go
Expand Up @@ -47,7 +47,8 @@ import (
)

const (
c2pScheme = "google-c2p-experimental"
c2pScheme = "google-c2p"
c2pExperimentalScheme = "google-c2p-experimental"

tdURL = "dns:///directpath-pa.googleapis.com"
httpReqTimeout = 10 * time.Second
Expand Down Expand Up @@ -75,10 +76,18 @@ var (
)

func init() {
resolver.Register(c2pResolverBuilder{})
resolver.Register(c2pResolverBuilder{
scheme: c2pScheme,
})
// TODO(apolcyn): remove this experimental scheme before the 1.52 release
resolver.Register(c2pResolverBuilder{
scheme: c2pExperimentalScheme,
})
}

type c2pResolverBuilder struct{}
type c2pResolverBuilder struct {
scheme string
}

func (c2pResolverBuilder) Build(t resolver.Target, cc resolver.ClientConn, opts resolver.BuildOptions) (resolver.Resolver, error) {
if !runDirectPath() {
Expand Down Expand Up @@ -131,8 +140,8 @@ func (c2pResolverBuilder) Build(t resolver.Target, cc resolver.ClientConn, opts
}, nil
}

func (c2pResolverBuilder) Scheme() string {
return c2pScheme
func (b c2pResolverBuilder) Scheme() string {
return b.scheme
}

type c2pResolver struct {
Expand Down

0 comments on commit 9eba574

Please sign in to comment.