Skip to content

Commit

Permalink
grpc: remove mentions of WithBalancerName from comments (#5555)
Browse files Browse the repository at this point in the history
  • Loading branch information
easwars committed Aug 2, 2022
1 parent a077b94 commit 9bc72de
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
7 changes: 3 additions & 4 deletions service_config.go
Expand Up @@ -57,10 +57,9 @@ type lbConfig struct {
type ServiceConfig struct {
serviceconfig.Config

// LB is the load balancer the service providers recommends. The balancer
// specified via grpc.WithBalancerName will override this. This is deprecated;
// lbConfigs is preferred. If lbConfig and LB are both present, lbConfig
// will be used.
// LB is the load balancer the service providers recommends. This is
// deprecated; lbConfigs is preferred. If lbConfig and LB are both present,
// lbConfig will be used.
LB *string

// lbConfig is the service config's load balancing configuration. If
Expand Down
2 changes: 0 additions & 2 deletions test/channelz_test.go
Expand Up @@ -1917,8 +1917,6 @@ func (s) TestCZTraceOverwriteChannelDeletion(t *testing.T) {
czCleanup := channelz.NewChannelzStorageForTesting()
defer czCleanupWrapper(czCleanup, t)
e := tcpClearRREnv
// avoid newTest using WithBalancerName, which would override service
// config's change of balancer below.
e.balancer = ""
te := newTest(t, e)
channelz.SetMaxTraceEntry(1)
Expand Down
1 change: 0 additions & 1 deletion vet.sh
Expand Up @@ -147,7 +147,6 @@ grpc.NewGZIPDecompressor
grpc.RPCCompressor
grpc.RPCDecompressor
grpc.ServiceConfig
grpc.WithBalancerName
grpc.WithCompressor
grpc.WithDecompressor
grpc.WithDialer
Expand Down

0 comments on commit 9bc72de

Please sign in to comment.