Skip to content

Commit

Permalink
grpc: un-deprecate Dial and DialContext
Browse files Browse the repository at this point in the history
  • Loading branch information
dfawley committed Apr 8, 2024
1 parent 58dc749 commit 0f6ef0f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions clientconn.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,6 @@ func NewClient(target string, opts ...DialOption) (conn *ClientConn, err error)
}

// Dial calls DialContext(context.Background(), target, opts...).
//
// Deprecated: use NewClient instead. Will be supported throughout 1.x.
func Dial(target string, opts ...DialOption) (*ClientConn, error) {
return DialContext(context.Background(), target, opts...)
}
Expand All @@ -211,8 +209,6 @@ func Dial(target string, opts ...DialOption) (*ClientConn, error) {
// "passthrough" for backward compatibility. This distinction should not matter
// to most users, but could matter to legacy users that specify a custom dialer
// and expect it to receive the target string directly.
//
// Deprecated: use NewClient instead. Will be supported throughout 1.x.
func DialContext(ctx context.Context, target string, opts ...DialOption) (conn *ClientConn, err error) {
// At the end of this method, we kick the channel out of idle, rather than
// waiting for the first rpc.
Expand Down

0 comments on commit 0f6ef0f

Please sign in to comment.