Improve logging message when gRPC status OK in header #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
halter73,
captainsafia,
BrennanConroy and
brunolins16
captainsafia
reviewed
Nov 2, 2022
| @@ -36,7 +36,8 @@ public async Task ThrowErrorWithOK_ClientThrowsFailedToDeserializeError() | |||
| { | |||
| SetExpectedErrorsFilter(writeContext => | |||
| { | |||
| if (writeContext.State.ToString() == "Message not returned from unary or client streaming call.") | |||
| if (writeContext.State.ToString() == "Header contains an OK gRPC status. This is invalid for unary or client streaming calls because a status in the header indicates there is no response body. " + | |||
There was a problem hiding this comment.
Worthwhile to store this message in a constant for use in the tests and implementation?
There was a problem hiding this comment.
This is the only place it is used in tests. We're not doing it for anything else so I'd like to leave it as is.
BrennanConroy
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1922