Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grpc benchmark cancellation #1901

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix grpc benchmark cancellation #1901

merged 1 commit into from
Oct 5, 2022

Conversation

BrennanConroy
Copy link
Contributor

Methods on CallOptions return a new instance of the options struct.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 5, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: BrennanConroy / name: Brennan (87bde8e)

@BrennanConroy
Copy link
Contributor Author

BrennanConroy commented Oct 5, 2022 •
edited

Still didn't help even if it is correct...

Edit: Branch wasn't being picked up, fixing command line shows this did fix the benchmark

@JamesNK JamesNK merged commit ad67dc8 into master Oct 5, 2022
@BrennanConroy BrennanConroy deleted the brecon/cancel branch October 5, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrennanConroy @JamesNK