-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Spring-Security/Authentication #122
Conversation
3c06e1b
to
dbbc8fa
Compare
@yidongnan I'm unable to see why the tests fail, they seem to fail randomly. |
e268dd0
to
dbbc8fa
Compare
It looks like it was a temporary travis issue. Ready for review and merge. |
@ST-DDT I executed the
|
Can you include the logs? |
|
I could observe the error myself now, but I still have no clue how to reproduce it. I look further into it. |
I guess I found the error, but I'm not sure since the bug is that hard to reproduce. While implementing the security layer I followed the existing templates too much (They all have the same error). In Grpc each callback can be called by a different thread (See SO), thus setting the security context only during the I will create a PR with a fix after I run the tests another 1000 times (probably tomorrow). |
Related: #49
Fixes: #50 , #69