fix(runtime): fix path parsing to use URL.EscapedPath() instead of Path and unescape individual components #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th and unescape individual components Basically we want to route for instance http://example.com/resources/some%2Fpath/something from this http annotation : get: /resources/{key}/something We want the key field in gRPC to be able to contain 0 or many slashes grpc-ecosystem#660
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, we want to route for instance http://example.com/resources/some%2Fpath/something from this HTTP annotation :
We want the key field in gRPC to be able to contain 0 or many slashes
Should this behavior be configurable to avoid breaking changes?
References to other Issues or PRs
#660
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
Other comments