Swagger 2.4.8 #1058
Merged
Swagger 2.4.8 #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2019 10:11
- had to update the makefile as the generated file names have all moved around a little bit - moved bazel forward to use go 1.13.1 as well - test that was using a deep reflect to do equality has changed to be per struct field equality (deep reflect no longer works with the enum types).
This is the best news I've heard in weeks. |
|
Would need one more dockerfile rebuild here. |
Codecov Report
@@ Coverage Diff @@
## master #1058 +/- ##
=======================================
Coverage 53.84% 53.84%
=======================================
Files 41 41
Lines 4147 4147
=======================================
Hits 2233 2233
Misses 1670 1670
Partials 244 244Continue to review full report at Codecov.
|
Co-Authored-By: Johan Brandhorst <johan.brandhorst@gmail.com>
|
Lets merge this, I'll do a rebuild of the image on master. |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* generate files with swagger-codegen 2.4.8 * swagger-codegen 2.4.8 is now the base requirement - had to update the makefile as the generated file names have all moved around a little bit - moved bazel forward to use go 1.13.1 as well - test that was using a deep reflect to do equality has changed to be per struct field equality (deep reflect no longer works with the enum types). * remove need for env var * adds -e plus refactors tools to top * Update .circleci/Dockerfile Co-Authored-By: Johan Brandhorst <johan.brandhorst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file names have all moved around a little bit
has changed to be per struct field equality (deep
reflect no longer works with the enum types).
as they use the standard lib for http requests.
Biggest bit - you cannot generate both an
rpcand a regularservicein the same directory at this version. Why? In our example they both use an optional type which used to be simple a string but nowswagger-codegencreates a struct. The struct has the same name for both versions and you get a type redeclaration (sad).Went and had a look at swagger-codegens repo for any open issues around this and saw 0. I don't think users actually do this so it seemed alright to remove it from our test generation.