Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces #427

Merged
merged 1 commit into from Jun 19, 2021

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 15, 2021

github.com/go-kit/kit split out just the logging interfaces to github.com/go-kit/log to allow downstreams to avoid inheriting large numbers of additional dependencies (made visible and impacting to go modules in v0.10.0 of github.com/go-kit/kit). xref prometheus/common#255

This switches to the slimmed down logging interface module to drop a ton of transitive dependencies introduced by go-kit/kit v0.10.0

cc @dims

@liggitt liggitt changed the title Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces v2: Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces Jun 15, 2021
@liggitt
Copy link
Contributor Author

liggitt commented Jun 15, 2021

cc @johanbrandhorst

README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #427 (f619f01) into v2 (a79558a) will decrease coverage by 27.56%.
The diff coverage is 40.60%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #427       +/-   ##
===========================================
- Coverage   83.58%   56.01%   -27.57%     
===========================================
  Files          30       38        +8     
  Lines         932     1346      +414     
===========================================
- Hits          779      754       -25     
- Misses        114      520      +406     
- Partials       39       72       +33     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/auth/metadata.go 100.00% <ø> (ø)
interceptors/logging/options.go 82.60% <0.00%> (-8.02%) ⬇️
interceptors/ratelimit/ratelimit.go 50.00% <0.00%> (-50.00%) ⬇️
interceptors/tags/fieldextractor.go 13.79% <0.00%> (-71.51%) ⬇️
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_extractfields.pb.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
testing/testpb/test.pb.go 36.92% <36.92%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6fb287...f619f01. Read the comment docs.

@liggitt
Copy link
Contributor Author

liggitt commented Jun 16, 2021

done

@johanbrandhorst johanbrandhorst merged commit cc20532 into grpc-ecosystem:v2 Jun 19, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants