Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JsonPbMarshalling interface #236

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

petervandenbroek
Copy link
Contributor

This allows for easy replacement by other marshallers.

See #235 for discussion on this.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
kamilmysliwiec Kamil Mysliwiec
This allows overriding this functionality with something the user provides.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for this PR. One small suggestion.

@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #236 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   71.57%   71.57%           
=======================================
  Files          37       37           
  Lines        1351     1351           
=======================================
  Hits          967      967           
  Misses        335      335           
  Partials       49       49
Impacted Files Coverage Δ
logging/logrus/payload_interceptors.go 84.12% <ø> (ø) ⬆️
logging/zap/payload_interceptors.go 84.61% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f080d...75b4a16. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
kamilmysliwiec Kamil Mysliwiec
…ceptors can be overridden.
@petervandenbroek
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@petervandenbroek
Copy link
Contributor Author

@googlebot I fixed it.

1 similar comment
@petervandenbroek
Copy link
Contributor Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@johanbrandhorst johanbrandhorst merged commit c523844 into grpc-ecosystem:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants