This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Optional groups for SQL based destinations #3083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
approved these changes
Mar 10, 2022
Comment on lines
+11
to
+18
| checkOptionsIntegrity(destinationOptions); | ||
| if ( | ||
| !destinationOptions.groupsTable || | ||
| !destinationOptions.groupForeignKey || | ||
| !destinationOptions.groupColumnName | ||
| ) { | ||
| newGroups = []; | ||
| } |
There was a problem hiding this comment.
I guess that works!
This will have the side-effect of deleting any previously-set groups you had saved in the table
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This PR contains the code to permit SQL based destinations to have optional groups.
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review