This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Add append, create and rename enrich, additive to upsert, update destination sync options
#2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
force-pushed
the
181244595-new-sync-modes
branch
from
19acdbf
to
612c39c
Compare
…ync modes Add destination configLoader test
edmundito
force-pushed
the
181244595-new-sync-modes
branch
from
9e53bd4
to
0e45c91
Compare
edmundito
commented
Feb 23, 2022
core/src/models/Destination.ts
Outdated
| displayName: "Additive", | ||
| upsert: { | ||
| key: "upsert", | ||
| displayName: "Upsert", | ||
| description: "Sync all records, but do not delete (create, update)", |
There was a problem hiding this comment.
I'm thinking we should also update these descriptions away from the word "sync". Any suggestions?
evantahler
reviewed
Feb 24, 2022
| @@ -860,6 +868,28 @@ describe("models/destination - with custom exportRecord plugin", () => { | |||
| await record.destroy(); | |||
| }); | |||
|
|
|||
| test("Append syncMode only allows creating records", async () => { | |||
| await record.destroy(); | ||
| }); | ||
|
|
||
| test("Create syncMode only allows creating records", async () => { |
core/src/models/Destination.ts
Outdated
| append: { | ||
| key: "append", | ||
| displayName: "Append", | ||
| description: "Create new records (create)", |
There was a problem hiding this comment.
Suggested change
| description: "Create new records (create)", | |
| description: "Always create new records (create)", |
Comment on lines
24
to
27
| log( | ||
| `[ config ] Found syncMode "${syncMode}" in Destination config "${configId}". "${syncMode}" is still supported but value should be updated to new name: "${newSyncMode}".`, | ||
| "warning" | ||
| ); |
There was a problem hiding this comment.
There's a DeprecationHelper to use for this kind of thing!
There was a problem hiding this comment.
Reminder about the Deprecation utility
| create: true, | ||
| update: false, | ||
| delete: false, | ||
| description: "Create new records, but only when they don't exist (create)", |
There was a problem hiding this comment.
Can these descriptions be retrieved from core? The boolean flags seem to be the same as well...
Fix invalid syncModes in snowflake connection
edmundito
force-pushed
the
181244595-new-sync-modes
branch
from
823c3c0
to
1e61b2d
Compare
pedroslopez
reviewed
Feb 24, 2022
Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>
evantahler
suggested changes
Feb 25, 2022
| description: values.description, | ||
| }); | ||
|
|
||
| export const BatchSyncModeData: Record<BatchSyncMode, BatchSyncModeDataValues> = |
Comment on lines
24
to
27
| log( | ||
| `[ config ] Found syncMode "${syncMode}" in Destination config "${configId}". "${syncMode}" is still supported but value should be updated to new name: "${newSyncMode}".`, | ||
| "warning" | ||
| ); |
There was a problem hiding this comment.
Reminder about the Deprecation utility
evantahler
approved these changes
Feb 28, 2022
|
(re-ran a flaky test) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This PR adds the ability to support
appendorcreate(create: true, update: false, delete: false) in destination apps. It also migrates theenrichandadditivesyncMode names to the more commonly known termsupdateandupsert.The db will migrate the syncModes to the new values. In config files,
enrichandadditiveare still supported but a warning is shown, and will be updated to the new value if the user updates the config via the UI.All plugins have been updated to use the new terms.
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Migrations considered:
grouparoo validate) and will continue to support the legacy values. However, if the user saves the config via the UI, the values are replaced with the new values.Code review