Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort runtime_logger output #924

Merged
merged 3 commits into from Nov 3, 2023

Conversation

lawrencegripper
Copy link
Contributor

@lawrencegripper lawrencegripper commented Nov 3, 2023

Show the slowest tests first in the runtime output file

Reason: I'm using this to profile and fixup slow tests so having them at the top is super useful.

Checklist

  • Feature branch is up-to-date with master (if not - rebase it).
  • Added tests. (adapted one rather than added)
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • NA Update Readme.md when cli options are changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to remove this one, as it's fairly vscode specific

Copy link
Owner

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better than before 👍

atm they are randomly sorted by when they finished
so runtime is a bit less crazy

the other thing I could imagine is ordering alphabetically
which help seeing diffs in runtime when committing a new runtime file
and avoids diff when runtime did not change (kinda unlikely)
also sorting by runtime could be easily done with an ad-hoc command if needed

since nobody really ever cared for this we might as well use runtime

@grosser grosser merged commit 6e9be6f into grosser:master Nov 3, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants