Support also feature files used by RSpec turnip gem. #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah that's much simpler than I expected :) |
|
4.3.0 |
|
I think this could be a bug for users using gherkin and rspec where their .feature files would previously not be run when using rspec, if they keep their files in the |
I was thinking about that, but those features are usually in |
|
let's do that if anyone runs into trouble
…On Mon, Oct 9, 2023 at 1:27 AM Josef Šimánek ***@***.***> wrote:
I think this could be a bug for users using gherkin and rspec where their
.feature files would previously not be run when using rspec, if they keep
their files in the spec folder. But let's see if anyone runs into that.
I was thinking about that, but those features are usually in features
folder and are not mixed in spec folder. Alternatively it could be
possible to check if Turnip is defined and enhance the lookup regexp only
in that case.
—
Reply to this email directly, view it on GitHub
<#919 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACYZ4URJDCUL5Q3PN7VO3X6OYPZAVCNFSM6AAAAAA5XDU4JWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGU2TCOBSGE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #271
ℹ️ tested in real project as well
before
after