Upgrade RuboCop and fix some offenses #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
commented
May 26, 2023
Comment on lines
+261
to
262
| '_spec.rb$' - matches rspec files | ||
| '_(test|spec).rb$' - matches test or spec files |
There was a problem hiding this comment.
Or, if we want a “regex escaped dot” \. in the output:
Suggested change
| '_spec.rb$' - matches rspec files | |
| '_(test|spec).rb$' - matches test or spec files | |
| '_spec\\.rb$' - matches rspec files | |
| '_(test|spec)\\.rb$' - matches test or spec files |
Ruby 2.5 compatibility is no longer a concern, so we can now upgrade to the very latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.5 compatibility is no longer a concern, so we can now upgrade to the very latest version.
Checklist
master(if not - rebase it).code introduces user-observable changes.