Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compatibility with RSpec 2 #908

Merged
merged 1 commit into from May 25, 2023
Merged

Remove compatibility with RSpec 2 #908

merged 1 commit into from May 25, 2023

Conversation

bquorning
Copy link
Contributor

RSpec 3 was released 9 years ago. Most people will have upgraded by now 馃槄

Checklist

  • Feature branch is up-to-date with master (if not - rebase it).
  • Added tests.
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • Update Readme.md when cli options are changed

@bquorning
Remove compatibility with RSpec 2
fad593d 
RSpec 3 was released 9 years ago. Most people will have upgraded by now 馃槄
@bquorning bquorning marked this pull request as ready for review May 25, 2023 20:14
grosser
grosser approved these changes May 25, 2023
View reviewed changes
Copy link
Owner

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鉂わ笍

@grosser grosser merged commit fed72e4 into grosser:master May 25, 2023
12 of 13 checks passed
@grosser
Copy link
Owner

grosser commented May 25, 2023

lmk if you need a release

@bquorning bquorning deleted the remove-rspec-2-compatibility branch May 25, 2023 20:44
@bquorning
Copy link
Contributor Author

lmk if you need a release

No no, I can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grosser grosser grosser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bquorning @grosser