Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more than one isolated process. #779
Add support for more than one isolated process. #779
Changes from 10 commits
8ca2d01
d33b04e
77320cc
41f203b
f3e2251
496ee09
477759a
a9ff592
04d811c
ce8bafe
00dd701
0826220
645d9a7
b94d283
58b4b71
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this triggers determine_number_of_processes twice when count was not given and duplicates the
count ||= determine_number_of_processes
logicso this check should move to where count is set or count default setting should move here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried moving num_processes determination to parse_options. Lot of specs fail - as they don't expect
:count
option. That does not feel right either - as parse_option should be just that.I prefer validation bounds check for all options inside parse_options. This keeps the code in appropriate places at the cost of calling determine_number_of_processes twice.
But I did move the validation for this inside the main
run
methodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that did not work as the specs fail as CLI specs call only the parse_options method.
I would leave it up to you.. Three ways to fix this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grosser ☝️ In case you have not seen the above reply yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done... Please do check the whole PR again with fresh set of eyes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is failing like this:
or
Specs pass locally.
Any ideas?