Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight availability of ParallelTests module #773

Merged
merged 2 commits into from Aug 11, 2020
Merged

Highlight availability of ParallelTests module #773

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b5c87b
Highlight availability of ParallelTests module
PragTob Aug 11, 2020
f967f8b
Add explicit require as a fix instead
PragTob Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Readme.md
View file
Open in desktop
Expand Up @@ -97,9 +97,10 @@ at_exit do
undo_something
end
end

```

_note:_ when using the standalone runners (`parallel_rspec`, `parallel_test`, ...) then the `ParallelTests` module isn't available.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though the fix would be to drop a require 'parallel_tests' at the top of the example ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I thought you said it might not even be available as it's not even necessarily in the Gemfile. Although, then it should still have access to the gem and if it ran with bundle exec the command itself shouldn't work so it might work... 🤔

Eh, I'm unsure but you're probably right. Good we talked about it. Say the word and I'll change it again :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the explicit require


Even test group run-times
=========================

Expand Down