Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove name override logic that never worked #758

Merged
merged 1 commit into from May 10, 2020
Merged

remove name override logic that never worked #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/parallel_tests/cli.rb
View file
Open in desktop
Expand Up @@ -316,9 +316,8 @@ def detailed_duration(seconds)
end

def final_fail_message
fail_message = "#{@runner.name}s Failed"
fail_message = "Tests Failed"
fail_message = "\e[31m#{fail_message}\e[0m" if use_colors?

fail_message
end

Expand Down
2 changes: 0 additions & 2 deletions lib/parallel_tests/rspec/runner.rb
View file
Open in desktop
Expand Up @@ -4,8 +4,6 @@ module ParallelTests
module RSpec
class Runner < ParallelTests::Test::Runner
DEV_NULL = (WINDOWS ? "NUL" : "/dev/null")
NAME = 'RSpec'

class << self
def run_tests(test_files, process_number, num_processes, options)
exe = executable # expensive, so we cache
Expand Down
6 changes: 0 additions & 6 deletions lib/parallel_tests/test/runner.rb
View file
Open in desktop
Expand Up @@ -3,15 +3,9 @@
module ParallelTests
module Test
class Runner
NAME = 'Test'

class << self
# --- usually overwritten by other runners

def name
NAME
end

def runtime_log
'tmp/parallel_runtime_test.log'
end
Expand Down