Add switch to log results to JSON file #630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --consolidated-results switch causes results like tests per process, time taken, and total failures to be logged to a JSON file at the path supplied.
grosser
reviewed
Apr 8, 2018
| end | ||
|
|
||
| def write_consolidated_results(consolidated_results, options) | ||
| return if options[:consolidated_results].nil? || options[:consolidated_results].empty? |
There was a problem hiding this comment.
not a big fan of supporting "" ... can simplify to return unless options[:consolidated_results]
grosser
reviewed
Apr 8, 2018
| @@ -216,6 +236,7 @@ def parse_options!(argv) | |||
| opts.on("--unknown-runtime [FLOAT]", Float, "Use given number as unknown runtime (otherwise use average time)") { |time| options[:unknown_runtime] = time } | |||
| opts.on("--first-is-1", "Use \"1\" as TEST_ENV_NUMBER to not reuse the default test environment") { options[:first_is_1] = true } | |||
| opts.on("--verbose", "Print more output") { options[:verbose] = true } | |||
| opts.on("--consolidated-results [PATH]", "Location to write consolidated test results") { |path| options[:consolidated_results] = path } | |||
|
hmm idk overall looks like a fair bit of added complexity to write a format that won't be useful to very many ... also missing any tests |
grosser
reviewed
Apr 8, 2018
| seconds = ParallelTests.delta { yield }.to_i | ||
| puts "\nTook #{seconds} seconds#{detailed_duration(seconds)}" | ||
| message = "Took #{seconds} seconds#{detailed_duration(seconds)}" | ||
| consolidated_results[:time_taken] = { |
There was a problem hiding this comment.
how long the command took is easily gathered by whatever process runs the parallel_tests command
also time_taken: seconds might be good enough, don't really need the custom format if this goes through post-processing anyway
grosser
reviewed
Apr 8, 2018
| @@ -28,7 +28,11 @@ def summarize_results(results) | |||
|
|
|||
| output << super | |||
|
|
|||
| output.join("\n\n") | |||
| consolidated_results[:summary] = { | |||
There was a problem hiding this comment.
output is everything the command prints, not sure why it needs to be in the json ... will make kit so much bigger ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --consolidated-results switch causes results like tests per process, time taken, and total failures
to be logged to a JSON file at the path supplied.
This is useful for us because we'd like to take these results and post them to our Github status checks.