Skip to content

Commit

Permalink
Drop ruby 2.3 support (#760)
Browse files Browse the repository at this point in the history
  • Loading branch information
deivid-rodriguez committed Jun 4, 2020
1 parent 1c8761a commit c68dec6
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.7, 2.6, 2.5, 2.4, 2.3]
ruby: [2.7, 2.6, 2.5, 2.4]
steps:
- uses: actions/checkout@master
- name: Set up Ruby
Expand Down
1 change: 0 additions & 1 deletion .travis.yml
@@ -1,7 +1,6 @@
env:
- RUBYOPT=-W0
rvm:
- 2.3
- 2.4
- 2.5
- 2.6
Expand Down
2 changes: 1 addition & 1 deletion parallel_tests.gemspec
Expand Up @@ -16,5 +16,5 @@ Gem::Specification.new name, ParallelTests::VERSION do |s|
s.license = "MIT"
s.executables = ["parallel_spinach", "parallel_cucumber", "parallel_rspec", "parallel_test"]
s.add_runtime_dependency "parallel"
s.required_ruby_version = '>= 2.3.0'
s.required_ruby_version = '>= 2.4.0'
end
2 changes: 1 addition & 1 deletion spec/integration_spec.rb
Expand Up @@ -426,7 +426,7 @@ def test_unicode
write "features/fail2.feature", "Feature: xxx\n Scenario: xxx\n Given I fail"
results = run_tests "features", :processes => 3, :type => "cucumber", :fail => true

failing_scenarios = if Gem.win_platform? && Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.4")
failing_scenarios = if Gem.win_platform?
["cucumber features/fail1.feature:2 # Scenario: xxx", "cucumber features/fail2.feature:2 # Scenario: xxx"]
else
["cucumber features/fail2.feature:2 # Scenario: xxx", "cucumber features/fail1.feature:2 # Scenario: xxx"]
Expand Down
2 changes: 1 addition & 1 deletion spec/parallel_tests/test/runner_spec.rb
Expand Up @@ -41,7 +41,7 @@ def call(*args)
end

it "uses given when passed found" do
result = Gem.win_platform? && Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.4") ? [["a", "b"], ["c"]] : [["a", "c"], ["b"]]
result = Gem.win_platform? ? [["a", "b"], ["c"]] : [["a", "c"], ["b"]]
expect(call(["a", "b", "c"], 2, group_by: :found)).to eq(result)
end

Expand Down

0 comments on commit c68dec6

Please sign in to comment.