Bugfix/ladwlo thread safety fix #22
Conversation
gmaven-runtime/pom.xml
Outdated
| <module>gmaven-runtime-1.6</module> | ||
| <module>gmaven-runtime-1.7</module> | ||
| <module>gmaven-runtime-1.8</module> | ||
| <module>gmaven-runtime-2.0</module> |
There was a problem hiding this comment.
profiles turn these on, any reason why these were added here?
There was a problem hiding this comment.
No, I just didn't realize there were profiles (and plain 'mvn install' complained about missing snapshot of gmaven-runtime-1.6). I removed that change - thanks.
There was a problem hiding this comment.
maybe the profiles aren't kicking on properly as they should, will have a look when I merge this. thx.
There was a problem hiding this comment.
I guess it's because the 1.x branch is old and unaware of jdk's >1.7. Since I built it with Java 8, no profile was matched to the JDK. Maybe I should have added a section for java8, but when I simply used -Pjava7 everything built fine.
ladwlo
force-pushed
the
bugfix/ladwlo-thread-safety-fix
branch
from
ce69d29
to
bb54417
Compare
|
FTR its unfortunate that older maven-plugins that are not marked as thread-safe are not adapted in a MT maven-execution to be run by a single thread; I recall there is a deeper problem in the integration that makes it not thread-safe but I don't remember what that is ATM. And sadly I never use the MT maven because many plugins don't play well with it, so I never run into these problems, but maybe the general ecosystem has improved wrt to the use of --threads. |
|
I fully agree. I did observe some suspicious behavior of liquibase plugin and groovy-eclipse-compiler in MT mode as well. Luckily, it seems that the set of maven plugins used in our project works quite well with threads - at least I haven't seen failures of our build process since making the gmaven plugin safe. |
Fix for issue #21