Bring build plugins and libraries up to date plus switch findbugs to spotbugs #240
Conversation
on spotbugs, I'm the maintainer on that. findbugs is the same original code line and long not retired. It points to this and it should be drop in place for your needs.
note: file management 3.1.0 is going to require code changes so this was necessary.
|
Missed content coming from file-management for same provided scope issue. If that module is upgraded, the code has to change as it uses slf4j so this last commit seemed the easier path for now. |
| <dependency> | ||
| <groupId>org.apache.maven</groupId> | ||
| <artifactId>maven-artifact</artifactId> | ||
| <version>${mavenVersion}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.maven</groupId> | ||
| <artifactId>maven-compat</artifactId> | ||
| <version>${mavenVersion}</version> | ||
| <scope>provided</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Can you give some more context of why these were added?
There was a problem hiding this comment.
Oh, I see. Because it was in the list of dependencies you got a warning about.
There was a problem hiding this comment.
These are transitive dependencies. After commenting these lines out out, mvnw dependency:tree shows
[INFO] +- org.apache.maven:maven-plugin-api:jar:3.0:provided
[INFO] | +- org.apache.maven:maven-artifact:jar:3.0:compile
and
[INFO] +- org.apache.maven.shared:file-management:jar:3.0.0:compile
[INFO] | \- org.apache.maven.shared:maven-shared-io:jar:3.0.0:compile
[INFO] | +- org.apache.maven:maven-compat:jar:3.0:compile
So I guess it's correct to add them.
There was a problem hiding this comment.
if the file-management is updated to 3.1.0 that would not have been needed but the gmavenplus code currently is passing a log that doesn't resolve as needed. So it seemed easier for a quicker pass on it to just override those to make maven happy for time being. That next file management doesn't contain those btw. And for whatever reason a build locally for me fails at the current master before this and I didnt' have time to look into that when GHA were completely fine.
|
@keeganwitt Thanks for quickly picking this up. |
No description provided.