Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MINOR/PATCH devDependencies #5494

Merged

Conversation

halocline
Copy link
Collaborator

What does this PR do?

  • Upgrade MINOR/PATCH devDependencies

Where should the reviewer start?

package.json

What testing has been done on this PR?

  • successful yarn build
  • successful yarn build-storybook
  • Commit test suite

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

#5476

Screenshots (if appropriate)

Do the grommet docs need to be updated?

No

Should this PR be mentioned in the release notes?

No

Is this change backwards compatible or is it a breaking change?

Backwards

@halocline
Copy link
Collaborator Author

Attempting to upgrade babel-plugin-styled-components from 1.12.0 to 1.13.1 was causing snapshot classNames to not match. This is due to this fix.

Will handle this upgrade in a separate PR as it will generate snapshot changes which will insert an 'sc-' prefix ahead of any styled-components hashes in our snapshots which lead with an [a-z] char instead of a [0-9] char.

Example

-     class="StyledClock__StyledDigitalDigit-y4xw8s-4 kqkWIg"
+     class="StyledClock__StyledDigitalDigit-sc-y4xw8s-4 jQnxXp"

@ericsoderberghp ericsoderberghp merged commit 682771d into grommet:upgrade-dependencies Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants