Restore convert filters to explicit naming feature #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd updated imports accordingly. Added new services for filter creation and saving with token authentication. Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Meklo
force-pushed
the
fix/restore_filter_explicit_naming_conversion
branch
from
c2a095b
to
36aee40
Compare
Put back the code with new Error() and update associated TS. Signed-off-by: Florent MILLOT <millotflo@gmail.com>
…plicit_naming_conversion
dbraquart
reviewed
May 16, 2024
There was a problem hiding this comment.
code: ok, the report of "Convert" code is OK
tests: works fine, but I found an issue (not a regression)
Test case:
- convert a filter with a study where we have some matching elements
- choose another study where there is no match : the previous list is still displayed.
This is very confusing. When we set an empty array, the table is not updated. I made a suggestion to display the default table... don't know if we can do better. It's up to you if you want to fix it, or leave it for later (in this case I will approve the PR as is).
Comment on lines
220
to
224
| matchingEquipments.map((equipment: any) => ({ | ||
| [FieldConstants.AG_GRID_ROW_UUID]: uuid4(), | ||
| [FieldConstants.EQUIPMENT_ID]: equipment.id, | ||
| [DISTRIBUTION_KEY]: equipment.distributionKey, | ||
| })) |
There was a problem hiding this comment.
Suggested change
| matchingEquipments.map((equipment: any) => ({ | |
| [FieldConstants.AG_GRID_ROW_UUID]: uuid4(), | |
| [FieldConstants.EQUIPMENT_ID]: equipment.id, | |
| [DISTRIBUTION_KEY]: equipment.distributionKey, | |
| })) | |
| matchingEquipments.length === 0 | |
| ? makeDefaultTableRows() | |
| : matchingEquipments.map((equipment: any) => ({ | |
| [FieldConstants.AG_GRID_ROW_UUID]: uuid4(), | |
| [FieldConstants.EQUIPMENT_ID]: equipment.id, | |
| [DISTRIBUTION_KEY]: equipment.distributionKey, | |
| })) |
dbraquart
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.