New hook to subscribe to announcements #405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ements). Signed-off-by: Florent MILLOT <millotflo@gmail.com>
This was referenced Mar 28, 2024
flomillot
changed the title
| @@ -98,6 +99,7 @@ | |||
| "utf-8-validate": "^5.0.2", | |||
| "@react-hook/window-size": "^3.1.1", | |||
| "react-resizable": "^3.0.4", | |||
| "reconnecting-websocket": "^4.4.0", | |||
There was a problem hiding this comment.
double declaration, can be removed
There was a problem hiding this comment.
Actually we need it in both peer and dev deps no ?
Comment on lines
+18
to
+21
| export function useAnnouncementsSubscriber( | ||
| webSocketUrl: string, | ||
| token: string | ||
| ) { |
There was a problem hiding this comment.
To keep concerns separate, shouldn't we pass the token in the URL directly in the hook, and then the hook does not mind about token issues ? Either it could connect or not.
There was a problem hiding this comment.
If I do that I'll have to read the string to know if the token is present or not, seems worse to me.
How would you do that ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add useAnnouncementsSubscriber hook to subscribe via websocket to global notifications (announcements).
When new message, it display a snackbar at the top of the page.
from gridsuite/gridstudy-app#1902 and gridsuite/gridexplore-app#346