Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade all the things! #178

Merged
merged 1 commit into from Aug 30, 2022
Merged

upgrade all the things! #178

merged 1 commit into from Aug 30, 2022

Conversation

jonenst
Copy link
Contributor

@jonenst jonenst commented Aug 29, 2022

babel/helper-builder-react-jsx held back because of babel/babel#14886,
can be upgraded once the fix is released

svgr needs to stay @v5: gregberge/svgr#665 (comment)
"We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5."

eslint-loader -> eslint-webpack-plugin @ v2
from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin"
from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch."

TODO: still need to do
"babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0",
eslint 7 -> 8
didn't work easily for me..

babel/helper-builder-react-jsx held back because of babel/babel#14886,
can be upgraded once the fix is released

svgr needs to stay @v5: gregberge/svgr#665 (comment)
"We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5."

eslint-loader -> eslint-webpack-plugin @ v2
from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin"
from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch."

TODO: still need to do
  "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0",
  eslint 7 -> 8
didn't work easily for me..
Copy link
Contributor

@sBouzols sBouzols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ok
Demo prog tested ok
console warning heck ok

@sBouzols sBouzols merged commit cdcaada into main Aug 30, 2022
@sBouzols sBouzols deleted the upgradeall branch August 30, 2022 15:00
Meklo pushed a commit that referenced this pull request Mar 25, 2024
-@babel/helper-builder-react-jsx 7.15.4 -> 7.22.10
#178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants