PR remarks

Signed-off-by: Florent MILLOT <millotflo@gmail.com>
gridsuite · May 15, 2024 · 7265770 · 7265770
1 parent 162cdf4
commit 7265770
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/components/filter/explicit-naming/explicit-naming-filter-edition-dialog.tsx b/src/components/filter/explicit-naming/explicit-naming-filter-edition-dialog.tsx
@@ -131,8 +131,7 @@ const ExplicitNamingFilterEditionDialog: FunctionComponent<
                         messageTxt: error,
                     });
                 },
-                onClose,
-                undefined
+                onClose
             );
             if (selectionForCopy.sourceItemUuid === id) {
                 setSelectionForCopy(noSelectionForCopy);

diff --git a/src/components/filter/utils/filter-api.ts b/src/components/filter/utils/filter-api.ts
@@ -22,7 +22,7 @@ export const saveExplicitNamingFilter = (
     id: string | null,
     setCreateFilterErr: (value: any) => void,
     handleClose: () => void,
-    activeDirectory: UUID | undefined,
+    activeDirectory?: UUID,
     token?: string
 ) => {
     // we remove unnecessary fields from the table

diff --git a/src/services/utils.ts b/src/services/utils.ts
@@ -13,9 +13,9 @@ export const backendFetch = (url: string, init: any, token?: string) => {
 };
 
 const prepareRequest = (init: any, token?: string) => {
-    if (!(typeof init == 'undefined' || typeof init == 'object')) {
+    if (!(typeof init === 'undefined' || typeof init === 'object')) {
         throw new TypeError(
-            'Argument 2 of backendFetch is not an object : ' + typeof init
+            'First argument of prepareRequest is not an object : ' + typeof init
         );
     }
     const initCopy = Object.assign({}, init);