Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 column mode loading, saving 12 column layout #2088

Merged
merged 1 commit into from Oct 23, 2022

Conversation

adumesny
Copy link
Member

Description

fix #1985
fix #1975 (oneColumnModeDomSort case)

  • we now handle DOM and addWidget() when temporally into 1 column mode better to save the full 12 column mode
  • also DOM reading will reverse-sort entries to lay them in 1 column mode correctly (like if you had started with 12 and scaled down)

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

fix gridstack#1985
fix gridstack#1975 (oneColumnModeDomSort case)

* we now handle DOM and addWidget() when temporally into 1 column mode better to save the full 12 column mode
* also DOM reading will reverse-sort entries to lay them in 1 column mode correctly (like if you had started with 12 and scaled down)
@adumesny adumesny merged commit 6227910 into gridstack:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant