Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix removeWidget() after it's gone from DOM #2083

Merged
merged 1 commit into from Oct 14, 2022
Merged

fix removeWidget() after it's gone from DOM #2083

merged 1 commit into from Oct 14, 2022

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Oct 14, 2022 •
edited

Description

  • make sure removeWidget() handles when item has been first removed from DOM (like Angular/React/Vue would do). This bug had been there for 3 years, but shown it's ugly head in v6.

fix #2081

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
fix removeWidget() after it's gone from DOM
6c0b236 
* make sure removeWidget() handles when item has been first removed from DOM (like Angular/React/Vue would do).
This bug had been there for 3 years, but shown it's ugly head in  v6.
@adumesny adumesny merged commit b9c8cec into gridstack:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resize handles disappear after removing grid element from the DOM
1 participant
@adumesny