Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more nested grid fixes #2066

Merged
merged 1 commit into from Oct 9, 2022
Merged

more nested grid fixes #2066

merged 1 commit into from Oct 9, 2022

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Oct 9, 2022

Description

more for #1009

  • fixed makeSubGrid() to migrate node content field as well (not just html dom)

  • save() now removes w,h of 1

  • fixed dragging sub-grid over another, dragging content out not deleting empty sub-grid

  • fixed test cases

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

more for gridstack#1009
* fixed makeSubGrid() to migrate node content field as well (not just html dom)
* save() now removes w,h of 1
* fixed dragging sub-grid over another, dragging content out not deleting empty sub-grid

* fixed test cases
@adumesny adumesny merged commit ebdd791 into gridstack:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant