Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using drag and drop to create nested Grids #2053

Merged
merged 1 commit into from Sep 26, 2022

Conversation

adumesny
Copy link
Member

Description

fix #1009 remaining issues

  • dragging out last item will nuke empty nested grid
  • dragging over item to create nested grid, will revert back to normal item if you continue to drag out
  • fixed CSS issues dragging nested in/out couple times

TODO: fix test cases, doc, more testing

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

fix gridstack#1009 remaining issues
* dragging out last item will nuke empty nested grid
* dragging over item to create nested grid, will revert back to normal item if you continue to drag out
* fixed CSS issues dragging nested in/out couple times

TODO: fix test cases, doc, more testing
@adumesny adumesny merged commit e64b0c4 into gridstack:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using drag and drop to create nested Grids
1 participant