dragging nested items no longer clipp #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix to make gridstack#992 better going forward as I'm focusing on nested grids again * dragging sub item between grids no longer get clipped by parent * removed basePosition.aboslute option as I'm not sure how we can make it work (parent has position.relative which will clip us otherwise) * nested.html you can drag pink items between grids (h5 case, JQ still clipps)
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Dec 23, 2021
* gridstack#1902 change caused a flicker when item goes posision:fixed, so make sure we position on screen during init as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(parent has position.relative which will clip us otherwise)
Checklist
yarn test)