New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using generic function to compute alphabet score for Cyrillic and latin #115
Conversation
THIS DEGRADES PERFORMANCE - TODO: IMPROVE
Ah, damn. Sorry! I've created that issue mostly as a reminder for myself. |
No problem, I didn't notice #116 Most likely no need to merge my PR then :) Also for my understanding - how important the performance for you in this code? |
@egorgrachev Thank you for understanding.
Generally I would prefer readability over performance and avoid premature optimizations. Whatlang is also used by Sonic search engine. I am closing this PR in favor of #116 |
@egorgrachev If you're interested in further contributions, let's stay in touch. |
#111
it degrades performance a bit, mostly because we re-compute alphabet lang map instead of having static variable. It's probably possible to optimise
on my pc cargo bench went from 5kk to 8kk ns