Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAW issues: #77

Closed
greiginsydney opened this issue Apr 3, 2021 · 4 comments
Closed

RAW issues: #77

greiginsydney opened this issue Apr 3, 2021 · 4 comments
Assignees
@greiginsydney
Labels
bug Something isn't working

Comments

@greiginsydney
Copy link
Owner

greiginsydney commented Apr 3, 2021 •
edited

  • Somewhere between PIL v7.0.0 and 8.1.2, the creation of a thumbnail from a Canon .RAW stopped working. makeThumb() logs an error.
  • If shooting RAW with "RAW + JPG" selected, you get dupes on the thumbnails page. Remediation: de-dupe.
  • If shooting in RAW, the "last image" on the home page is a .CR2 or .NEF (RAW) filename, and thus doesn't show in the browser. Remediation: use the thumbnail or related JPG for this image.
@greiginsydney greiginsydney added the bug Something isn't working label Apr 3, 2021
@greiginsydney greiginsydney self-assigned this Apr 3, 2021
@greiginsydney
Copy link
Owner Author

Raised issue python-pillow/Pillow#5385 in the hope the first problem can be resolved without needing to change intvlm8r code.

@greiginsydney
Copy link
Owner Author

The RAW thumbnail issue appears to have been resolved in PIL, but probably won't see the light of day until 8.3.0 due July 1st.
Refer python-pillow/Pillow#5452

greiginsydney added a commit that referenced this issue Jun 17, 2021
@greiginsydney
Updated .RAW image link on main page with .JPG
1cd7e21 
(Assuming one exists. This is if you're shooting in raw+JPG mode)
Partly addresses Issue #77
greiginsydney added a commit that referenced this issue Jun 17, 2021
@greiginsydney
If shooting RAW, display thumbnail on the main page
220402b 
Partly addresses Issue #77
greiginsydney added a commit that referenced this issue Jun 17, 2021
@greiginsydney
Moved path manipulation upstream (to .py)
5b67cbf 
Partly addresses Issue #77
greiginsydney added a commit that referenced this issue Jun 19, 2021
@greiginsydney
Bugfix: NOW correctly shows thumb on main page
5ad95b2 
(and on click).
NB, showing the thumb is a band-aid/safety-net. A higher-res JPG will come shortly.
Partly addresses Issue #77
@greiginsydney
Copy link
Owner Author

Partly addressed in release 4.1.1 - the "last image" on the home page now displays the preview of a RAW, or the thumbnail (if a preview does not exist).

The Canon RAW issue has been resolved with the release of PIL v8.3.0, as hoped-for.

Still to come: de-dupe on the thumbs page.

@greiginsydney
Copy link
Owner Author

The 'rename on copy' capability I'm adding in 4.3.0 makes it much harder to reliably test for a dupe filename, so I'm going to abandon the thumbs de-dupe idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greiginsydney greiginsydney

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greiginsydney