chore: change svgo - disabled remove viewBox #908
Closed
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gregberge
approved these changes
Oct 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #908 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 32 32
Lines 763 763
Branches 258 258
=======================================
Hits 712 712
Misses 50 50
Partials 1 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think it is very important to leave this option off by default.
1 - original files have this option (e.g. copied from figma)
2 - not many people care about the correctness of the converted file, and the absence of this parameter is very surprising in the end when the height and width are changed svg incorrectly displayed.
Test plan