Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website, next.js instructions #898

Merged
merged 1 commit into from Nov 18, 2023
Merged

Website, next.js instructions #898

merged 1 commit into from Nov 18, 2023

Conversation

jarimustonen
Copy link
Contributor

Summary

Test plan

Fixed next.config.js example to a working version per this:
#860 (comment)
@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svgr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 3:50pm

@jarimustonen
Copy link
Contributor Author

A fix for this issue: #897

@gregberge
Copy link
Owner

Thanks @jarimustonen, seems like there is a problem in deployment, maybe you could give a look?

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #898 (c6b3833) into main (ae91e2e) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          32       32           
  Lines         760      760           
  Branches      251      255    +4     
=======================================
  Hits          706      706           
  Misses         53       53           
  Partials        1        1           
Files Changed Coverage Δ
packages/core/src/config.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vltansky
Copy link
Contributor

@gregberge
Please merge this. Took me too much time to find the solution for svgr + nextjs setup... docs should be updated.
deploy fail doesn't look like caused by this pr.

@gregberge gregberge merged commit b0aef6e into gregberge:main Nov 18, 2023
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants