Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the existing title case by using element instead of value (children) #315

Merged
merged 5 commits into from
Jun 10, 2019
Merged

Handle the existing title case by using element instead of value (children) #315

merged 5 commits into from
Jun 10, 2019

Commits on May 24, 2019

  1. update(titleProp): title prop should fallback to svg's title if title… 

    … is not provided and titleProps is set to true
    @sudkumar
    sudkumar committed May 24, 2019
    Configuration menu
    Copy the full SHA
    1dbbfdd View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. update(expression): use instead of for fallback title prop

    @sudkumar
    sudkumar committed May 28, 2019
    Configuration menu
    Copy the full SHA
    0c04915 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Merge branch 'master' of https://github.com/smooth-code/svgr

    @sudkumar
    sudkumar committed May 29, 2019
    Configuration menu
    Copy the full SHA
    70fe5de View commit details
    Browse the repository at this point in the history

  2. fix(titleProp): titleProp should handle existing title with all cases of 

    children

Instead of return the children of title from conditional expression, we
can return the title element itself e.g.
if title is undefined then retun the existing title else return
<title>{title}</title>

fixes #314
    @sudkumar
    sudkumar committed May 29, 2019
    Configuration menu
    Copy the full SHA
    fa1ba14 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. refactor(tests): remove loops and test individually

    @sudkumar
    sudkumar committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    7172429 View commit details
    Browse the repository at this point in the history