Implements #449 Make authentication details available in MovingMessage #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble in MovingMessage * Implements greenmail-mail-test#449: Stores the authentication details in the moving message so that it is available in e.g. MessageDeliveryHandler * Since different authentication methods have different details, there's a AuthenticationState base interface with PlainAuthenticationState (with an additional authorizationId) and LoginAuthenticationState POJOs for the currently supported AUTH mechanisms LOGIN and AUTH. Other AUTH mechanisms may or may not have a username and/or password. * What I don't fully understand is why the SMTPState needs to be cleared so often. It's also cleared by the MailCommand, which removes the authentication details from the MovingMessage. I modfied the MailCommand so that it clears the SMTPState, but transfers the authentication details from the old moving message to the new one. We could also store the authentication details in the SMTPState as well, but that feels a bit redundant. * When I run the tests locally, the DummySSLServerSocketFactoryTest#testLoadKeyStoreViaSystemProperty fails, but that's because I don't have a certificate with an `amazonrootca1` in my system root key store (there is, e.g. a `debian:amazon_root_ca_1.pem` certificate and when I change the test to use that, it passes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #449: Stores the authentication details in the moving message so that it is available in e.g.
MessageDeliveryHandler. See also theExampleFindUserByAuthLoginTest.Would be great if you could pick this into the 1.6.x branch, since we can't switch to the new Jakarta namespace quite yet. I tried cherry picking this commit into the release-1.6.7 tag, there don't seem to be any merge conflicts.
the currently supported AUTH mechanisms LOGIN and AUTH. Other AUTH mechanisms may or may not have a username and/or password.
the authentication details in the SMTPState as well, but that feels a bit redundant.
amazonrootca1in my system root key store (there is, e.g. adebian:amazon_root_ca_1.pemcertificate and when I change the test to use that, it passes)Pop3State, but I didn't see any use for that where that info might be useful.