Opensight UI #4000
Open
Opensight UI #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
bjoernricks
force-pushed
the
opensight-ui
branch
3 times, most recently
from
b8fa166
to
78705c5
Compare
bjoernricks
force-pushed
the
opensight-ui
branch
7 times, most recently
from
936d35d
to
e760cc0
Compare
bjoernricks
force-pushed
the
opensight-ui
branch
8 times, most recently
from
cc639f5
to
1e3f27f
Compare
Start to implement new UI components for GSA.
Both components are based on mantine and flexbox. They are intended to replace Layout especially in dialogs.
All form components should be able to call the onChange handler with the value, name pair. Therefore introduce a generic hook to abstract the event handling.
Use latest release of userEvent.
The theme provider is required to be able to test components based on opensight-ui and mantine.
The useDownload hook in conjunction with the Download component should replace the withDownload HOC in future.
The snapshot test are not very useful and prone for changes which get applied without a deeper review.
Snapshots are flacky and not really useful.
Add testing function for easier testing the behavior of multiselect components.
Besides getting the footer and body also allow to get the header of a table.
When clicking on multiselects sometimes user event complained about `pointer-events` css property being `none`. Avoid this issue by not checking for `pointer-event` at all.
The emotion library has a check if global vi or jest is set to detect if it is running in a testing environment. Therefore just an empty vi object for the tests to keep it quiet.
Add a draft for toggling the language between en and de via a language switcher in the app header.
asset-mangement is an external application and therefore internal links can't be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Proof of Concept for a refreshed UI based on OpenSight and mantine.
Why
Our current UI looks a bit dated and this PR checks the possibility for easy and possible changed for a refreshed UI.
References
DEVOPS-1000
Checklist