-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Added a dedicated view for compliance audit reports #3952
base: main
Are you sure you want to change the base?
Conversation
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3952 +/- ##
==========================================
- Coverage 59.97% 59.64% -0.33%
==========================================
Files 1025 1043 +18
Lines 25238 26255 +1017
Branches 7468 7806 +338
==========================================
+ Hits 15136 15660 +524
- Misses 9158 9608 +450
- Partials 944 987 +43 ☔ View full report in Codecov by Sentry. |
dcd49bf
to
0fa51d0
Compare
eb4a4af
to
b717560
Compare
f2a6c69
to
811e5a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all this PR looks good. My comments are mostly only style and convention related.
Some rules that should be considered:
- In JS we agreed on camelCase usage for functions, classes, variables and properties finally. Because I have a Python background and wrote most of the initial code we still have a lot of snake_case naming which we never get rid of. All new additions should use camelCase when possible. Personally I am not sure if this fits here with the report still using snake_case and the strong coupling between the audit, tasks, scan configs, policies and the two different reports.
- We agreed on using absolute imports without the
.js
suffix some while ago. This might not be consistent on all places. - New react components should be function components if possible. React class components are still supported and will be supported a long time but are considered legacy. And because you can't use hooks inside class components it is better to write only function components for new code.
Thank you for your review @bjoernricks. I applied the review suggestions where possible and also rewrote |
83a22c9
to
8a16fa8
Compare
a4a9c06
to
b474908
Compare
- Compliance reports are now listed under Resilience tab and do not appear anymore under Scans tab. - A dedicated view for a compliance report now shows compliance of results. - Delta compliance reports can now highlight changes in compliance.
- Audit task reports should now open in audit reports detail page.
- Differentiate between report actions and audit report actions. - Differentiate between delta report and delta audit report reducers.
- Added compliance to default filters for audit reports and results.
- Rewrite auditdeltadetailspage, auditdetailspage, auditreportlistpage, compliancelevelsgroup into functional components. - Use camel case instead of snake case - Use absolute imports without .js suffix
Rename *.js to *.jsx and make sure tests are running again.
b474908
to
349acd0
Compare
What
Why
Currently GSA doesn't distinguish between different types of reports (vulnerability, compliance audit, etc.). Therefore there is no dedicated view yet, causing all filters to be accessible in different reports.
References
GEA-397
requires greenbone/gvmd#2125
requires greenbone/gsad#164