[BUGFIX] Show FDS Asset name in DataDocs #9950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilo59
commented
May 21, 2024
Comment on lines
+986
to
+987
| batch_kwargs = validation_results.meta.get("batch_kwargs", {}) | ||
| batch_spec = validation_results.meta.get("batch_spec", {}) |
There was a problem hiding this comment.
One of both of these may be going away in V1 but active_batch_definition will still be present.
Kilo59
commented
May 21, 2024
Comment on lines
+980
to
+985
| def _resolve_asset_name(validation_results: ExpectationValidationResult) -> str | None: | ||
| """ | ||
| Resolve the asset name from the validation results meta data. | ||
| FDS does not store data_asset_name in batch_kwargs or batch_spec and it must be | ||
| pulled from the active batch definition. | ||
| """ |
There was a problem hiding this comment.
@morphatic Thanks so much for the detailed issue description.
I ended up using exactly what you suggested.
Would you like me to make you a CoAuthor on this PR?
There was a problem hiding this comment.
Glad it helped! I would not complain about being listed as a co-author. Thank you for asking!
billdirks
approved these changes
May 21, 2024
| @@ -4832,7 +4839,7 @@ def get_validation_result( # noqa: PLR0913 | |||
| # run_id_set = set([key.run_id for key in filtered_key_list]) | |||
| if len(filtered_key_list) == 0: | |||
| logger.warning("No valid run_id values found.") | |||
| return {} | |||
| return {} # type: ignore[return-value] | |||
There was a problem hiding this comment.
Maybe make the return type a union with a dict so you don't have to ignore this here? This may cause you to assert at the call sites though.
Co-authored-by: morphatic <morphatic@users.noreply.github.com>
Shinnnyshinshin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing
Asset Namefor Fluent Datasources in the Datadocs Home/index page.See issue below for detailed description of the problem.
Also updates some related type annotations.
Before
After