Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(category, product): move selectProductsByIds selector to cat… #492

Merged
merged 2 commits into from
Oct 22, 2019
Merged

refactor(category, product): move selectProductsByIds selector to cat… #492

merged 2 commits into from
Oct 22, 2019

Conversation

lderrickable
Copy link
Contributor

…egory module and fix the selector

Also, make the category transformer set the id to the magento sku.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

@lderrickable lderrickable added package: product @daffodil/product package: category @daffodil/category labels Oct 22, 2019
@lderrickable lderrickable requested a review from a team October 22, 2019 14:22
@lderrickable lderrickable self-assigned this Oct 22, 2019
damienwebdev
damienwebdev previously approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

@damienwebdev damienwebdev added this to In progress in The Product Package via automation Oct 22, 2019
@damienwebdev
Copy link
Member

The build failing appears to be caused by ng-packagr/ng-packagr#1405

The Product Package automation moved this from In progress to Needs review Oct 22, 2019
damienwebdev
damienwebdev approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The Product Package automation moved this from Needs review to Reviewer approved Oct 22, 2019
@lderrickable lderrickable merged commit ebc7000 into develop Oct 22, 2019
The Product Package automation moved this from Reviewer approved to Done Oct 22, 2019
@damienwebdev damienwebdev deleted the product_category_stuff branch October 26, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienwebdev damienwebdev damienwebdev approved these changes

Assignees

@lderrickable lderrickable

Labels
package: category @daffodil/category package: product @daffodil/product
Projects
No open projects
The Product Package
  
Done
Milestone
v0.9.0 - The Product Package
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lderrickable @damienwebdev